search

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License
48 stars 111 forks source link

fix: Race condition on quickly setting and getting config #188

Closed rokusottervanger closed 2 years ago

rokusottervanger commented 2 years ago

fixes #187 by using the server's response to the set service to update the latest configuration.

gbiggs commented 2 years ago

Can you please provide a minimal, reproducible example that can be used to test this PR fixes the problem?

gbiggs commented 2 years ago

Thanks for the test, which I got to fail without the fix and pass with the fix. Thanks also for the contribution!

rokusottervanger commented 2 years ago

I need this fix on a ROS Melodic system as well. Should I make a new PR backporting this fix? What is the best way forward?

gbiggs commented 2 years ago

We'll handle backporting to melodic.