search

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License
48 stars 111 forks source link

Various fixes #98

Open eric-wieser opened 6 years ago

eric-wieser commented 6 years ago

I can split these up if any are objectionable

Last commit is the most valuable - it allows quotes in default values, descriptions, and enum info

eric-wieser commented 6 years ago

Looks like I forgot to update the unit tests with the quoted values

mikaelarguedas commented 6 years ago

Thanks @eric-wieser for the patch and the patience. I'd like to split the syntax improvements (use with statements, new-style classes) from the feature extension. I will open a PR with a subset of these commits if that's fine with you. If you get a chance to update the tests to match the descriptions modified in this PR, it would be much appreciated