Added virtual destructor for AbstractParamDescription

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License

48 stars 111 forks source link

Added virtual destructor for AbstractParamDescription #99

Closed DieHertz closed 4 years ago

DieHertz commented 6 years ago

AbstractParamDescription should have a virtual desctructor as it's used as a base for non-empty ParamDescription<T> and is deleted through the pointer onto base type instance.

meyerj commented 5 years ago

The same problem also affects AbstractGroupDescription (ConfigType.h.template:109).

mjcarroll commented 4 years ago

Thanks for the patch, I ended up taking the changes from #136/#149 for noetic.