remove the implicit dependency on catkin

ros / genmsg

Standalone Python library for generating ROS message and service data structures for various languages

http://wiki.ros.org/genmsg

29 stars 74 forks source link

remove the implicit dependency on catkin #62

Closed dirk-thomas closed 8 years ago

dirk-thomas commented 8 years ago

The function assert_file_exists is provided by catkin but the package doesn't run-depend on it (and probably shouldn't just for this trivial function).

Replaces #61.

dirk-thomas commented 8 years ago

@gerkey Can you please check that this works for your use case.

gerkey commented 8 years ago

With that patch, here's the next error:

-- Using these message generators: 
CMake Error at /opt/ros/jade/share/genmsg/cmake/genmsg-extras.cmake:124 (catkin_destinations):
  Unknown CMake command "catkin_destinations".
Call Stack (most recent call first):
  CMakeLists.txt:4 (add_message_files)

dirk-thomas commented 8 years ago

Hm, I just see how deep the rabit hole goes. I don't think it is feasible to remove the run dependency on catkin. The extra file uses many catkin variables and removing all of those would also imply that changing them in catkin wouldn't affect the message generation anymore. I guess I will close this and we continue on your original PR.