search

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
173 stars 274 forks source link

tf_echo argument inconsistency #111

Closed gaya- closed 8 years ago

gaya- commented 8 years ago

In tf_echo the source frame and target frame are mixed up, namely, the parent frame is called the "source frame" and the child is the "target", whereas everywhere else in TF and TF2 the convention is the opposite.

E.g. here the first argument is called "source_frameid" but it actually is the target frame id.

This inconsistency is really confusing, especially as it's not just the tf_echo but also the TF tutorials use the convention opposite from the actual implementation.

Should I make a PR for tf_echo and fix the tutorials afterwards?

tfoote commented 8 years ago

Duplicate: #108

gaya- commented 8 years ago

My bad, only checked the list of open issues.

Using "parent_frame" and "child_frame" instead of "source" and "target" might help to alleviate the confusion in the future...

ros-discourse commented 5 months ago

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/nomenclature-of-tf-echo-and-tf-listener/36985/7