tf: vector3.h remove uncesseray affectation found by Clang static analyze

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.

173 stars 274 forks source link

tf: vector3.h remove uncesseray affectation found by Clang static analyze #124

Closed tmoinel closed 7 years ago

tmoinel commented 8 years ago

Remove last minVal and maxVal affectation since it's not used after.

Also refactoring the first assignment to the first element.

tfoote commented 8 years ago

This looks good to me.

This is a fork of the bullet physics implementation. Could you submit it upstream first? https://github.com/bulletphysics/bullet3/blob/master/src/LinearMath/btVector3.cpp We'd prefer to track upstream implementation to not diverge our fork if there are changes that they do not accept.

There's also a version embedded in tf2 which should be patched as well: https://github.com/ros/geometry2/blob/indigo-devel/tf2/include/tf2/LinearMath/Vector3.h

tfoote commented 7 years ago

I'll also note that it's recommended to use the upstream bullet version not this embedded version. I'm going to close this until it's accepted upstream.