search

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
173 stars 274 forks source link

Add version of static tf publisher with fewer args #125

Closed DLu closed 7 years ago

tfoote commented 7 years ago

This is valid and would work but I'm concerned about adding another version of the api when this entire codepath can be resolved by adding 0 0 0 0 0 0 1000 and then there's no special casing. This improves readability of launch files since the transforms are consistently written out and the timing is explicitly set too. So I'm kind of leaning toward not accepting this. Since to do it properly we should add more tests to make sure it doesn't regress. And lastly this is also replaced by the static transform publisher in tf2.

tfoote commented 7 years ago

On balance I think that adding this complexity to the command line does not make sense with the simple workaround and the other options.