search

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
173 stars 274 forks source link

address gcc6 build error #143

Closed bulwahn closed 7 years ago

bulwahn commented 7 years ago

With gcc6, compiling fails with stdlib.h: No such file or directory, as including '-isystem /usr/include' breaks with gcc6, cf., https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.

This commit addresses this issue for this package in the same way it was addressed in various other ROS packages. A list of related commits and pull requests is at ros/rosdistro#12783.

I identified this issue when updating the orocos_kdl package to the current git commit: https://github.com/orocos/orocos_kinematics_dynamics/commit/d798f594552cb6f6223981b9c304d3db2b6a7d18

The issue occurred when compiling tf_conversions with this updated orocos_kdl.

This commit addresses for tf_conversions the same issue as b0d31cc1e9a43b45d216ee7f804e901a5c0f8936 was addressing for tf.

bulwahn commented 7 years ago

As I see it, the kinetic build job is more rigorous than indigo and jade build job, and is presented here as failing build job, because the proposed commit caused the line number of a CMake warning to change. So essentially, the number of warnings remain as-is and the build jobs show no regressions.

tfoote commented 7 years ago

Thanks! Yeah the Kinetic is stricter and unfortunately github doesn't differentiate between warnings and errors. And the cmake_modules causes warnings in all downstream packages right now.