search

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
173 stars 274 forks source link

Make python scripts Python3 compatible. #151

Closed de-vri-es closed 7 years ago

de-vri-es commented 7 years ago

This is basically #67 but rebased on indigo-devel. Also, since 707eb4119d641e1776744dd84ae99ab9cfaddd91 removed pytf.cpp, everything touching that is gone. That should make it much easier to merge this.

I squashed the original python fixes by @pallegro and added a few more in a second commit.

nuclearsandwich commented 7 years ago

@ros-pull-request-builder retest this please.

de-vri-es commented 7 years ago

Is this test failure related to these changes? I don't see how the changes could affect the line that throws the error.

tfoote commented 7 years ago

Thanks for the patches!

The test failures are due to a required coordinated release between geometry2 and geometry. The current branch requires the unreleased version of geometry2. (It's out on lunar which is why it passes there. But the others are queued.

de-vri-es commented 7 years ago

thanks :)