search

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
173 stars 274 forks source link

preserve constness to avoid compiler warnings #167

Closed rhaschke closed 6 years ago

rhaschke commented 6 years ago

Minor fix to avoid compiler warning when more string option -Wcast-qual is used: https://travis-ci.org/ros-planning/moveit/jobs/400755736

tfoote commented 6 years ago

This is in the fork of the Bullet Linear Math library. Since it's just triaging a warning and not diverging I can accept this. If you have a moment I'd recommend you make the same PR upstream against bullet.

https://github.com/bulletphysics/bullet3/blob/master/src/LinearMath/btVector3.h#L1243 and https://github.com/bulletphysics/bullet3/blob/master/src/LinearMath/btVector3.h#L1254

rhaschke commented 6 years ago

This is in the fork of the Bullet Linear Math library. Since it's just triaging a warning and not diverging I can accept this. If you have a moment I'd recommend you make the same PR upstream against bullet.

Done: https://github.com/bulletphysics/bullet3/pull/1843

tfoote commented 6 years ago

Great thanks for taking the time to do that @rhaschke !

rhaschke commented 5 years ago

@tfoote Do you plan a new release to resolve this issue (or #179) publicly?

tfoote commented 5 years ago

There's not a specific plan to make a release since we've only had small fixups. But a new release before hitting EOL would likely be good to do. I'll add it to my todo list.

rhaschke commented 5 years ago

Thanks! Since we check for warnings in MoveIt's CI, it's annoying to explicitly work-around those external issues.