ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
173 stars 275 forks source link

update how c++11 requirement is added #184

Closed kejxu closed 5 years ago

kejxu commented 5 years ago

update how c++11 compiler flag is added:

the other way to do this is to use target_compile_features(mylib PUBLIC cxx_std_11) from cmake, but this would mean to add this line for every target. would this be preferred instead of adding a global c++11 flag?

tfoote commented 5 years ago

If MSVC is using c++14 by default we shouldn't need to downgrade it for this. Can we just skip the declaration on Windows?

kejxu commented 5 years ago

If MSVC is using c++14 by default we shouldn't need to downgrade it for this. Can we just skip the declaration on Windows?

sure, this was mentioned during our porting too. would we want to keep check_cxx_compiler_flag(-std=c++11 COMPILER_SUPPORTS_CXX11) for G++ or change to just skip this check for MSVC?

tfoote commented 5 years ago

We might as well improve the linux logic to check for it before applying it. And then just skip it on MSVC.

kejxu commented 5 years ago

We might as well improve the linux logic to check for it before applying it. And then just skip it on MSVC.

updated to skip /std:c++11 check for msvc and updated comment