search

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
172 stars 274 forks source link

Fix view_frames by removing legacy version check. #222

Closed MichaelGrupp closed 2 years ago

MichaelGrupp commented 3 years ago

It crashed in Python 3 (Noetic) because of a missing byte string conversion. Given that this code block had some other potentials for bugs and that graphviz 2.8 is from 2006, it should be safe to simplify it to a single check_call.

MichaelGrupp commented 3 years ago

Previous error was:

rosrun tf view_frames

Listening to /tf for 5.0 seconds
Done Listening
b'dot - graphviz version 2.43.0 (0)\n'
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/tf/view_frames", line 119, in <module>
    generate(dot_graph)
  File "/opt/ros/noetic/lib/tf/view_frames", line 89, in generate
    m = r.search(vstr)
TypeError: cannot use a string pattern on a bytes-like object
MichaelGrupp commented 3 years ago

related to #201, see my comment there.

Should be combined with #217 IMO.