search

ros / geometry

Packages for common geometric calculations including the ROS transform library, "tf". Also includes ROS bindings for "bullet" physics engine and "kdl" kinematics/dynamics package.
172 stars 274 forks source link

fixed bug - quaternion_from_euler changing input in array of 1 dimension #236

Closed eladpar-rnd closed 1 year ago

eladpar-rnd commented 2 years ago

after lots of debugging a code using the "tf_conversions.transformations.quaternion_from_euler" we found out that when passing an argument that is a 1-dimension array , the function changes it by half

small fix to a big nasty problem it created :)

v4hn commented 1 year ago

ouch. now that's an annoying detail.

@eladpar-rnd why did you never clean up your patch here? This obviously breaks with normal float inputs (which is what you usually pass in there).

tfoote commented 1 year ago

Superseded by #241