[Windows][melodic-devel] Fix install locations

ros / geometry2

A set of ROS packages for keeping track of coordinate transforms.

190 stars 275 forks source link

[Windows][melodic-devel] Fix install locations #442

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

corrected the install locations per catkin guide.
- http://docs.ros.org/melodic/api/catkin/html/howto/format2/building_libraries.html
- http://docs.ros.org/melodic/api/catkin/html/howto/format2/building_executables.html
generalized the install for the target of tf2_py.

seanyen commented 4 years ago

@tfoote @dirk-thomas @rhaschke This is ready for review and merge. Thanks!

dirk-thomas commented 4 years ago

The changes the location of installed executables - putting them in bin / on the PATH rather than placing them in libexec where they are supposed to be invoked withrosrun`. That sounds like a breaking / undesired change to me.

tfoote commented 4 years ago

I think this is changing the install rules the RUNTIME DESTINATION for libraries only. Do the libraries on Windows get installed to the RUNTIME DESTINATION not the LIBRARY DESTINATION?

dirk-thomas commented 4 years ago

I think this is changing the install rules the RUNTIME DESTINATION for libraries only.

Ok, I missed that part. Sorry for the noise - ignore my previous comment.

seanyen commented 4 years ago

Do the libraries on Windows get installed to the RUNTIME DESTINATION not the LIBRARY DESTINATION?

@tfoote On CMake\Windows, the shared library .DLL is treated as a RUNTIME target so it gets installed to RUNTIME DESTINATION.

A quote from CMake manual:

RUNTIME Executables are treated as RUNTIME objects, except those marked with the MACOSX_BUNDLE property on macOS (see BUNDLE below.) For DLL platforms (all Windows-based systems including Cygwin), the DLL part of a shared library is treated as a RUNTIME target.