Fix Python Linking on OSX

ros / geometry2

A set of ROS packages for keeping track of coordinate transforms.

189 stars 275 forks source link

Open Tobias-Fischer opened 3 years ago

Tobias-Fischer commented 3 years ago

In https://github.com/RoboStack/ros-noetic/issues/86 we discovered that import tf2_py results in a segmentation fault on OSX. We previously observed similar issues with cv_bridge: https://github.com/ros-perception/vision_opencv/pull/331 which also contains links to why the proposed solution here works (see https://github.com/pytorch/pytorch/commit/73f6715f4725a0723d8171d3131e09ac7abf0666).

Tobias-Fischer commented 3 years ago

This patch was verified in RoboStack where it fixes the segfault.

Tobias-Fischer commented 3 years ago

Ping @tfoote

MatthijsBurgh commented 2 years ago

@tfoote friendly ping; Waiting for your approval and merging.