search

ros / geometry2

A set of ROS packages for keeping track of coordinate transforms.
189 stars 275 forks source link

Longer char array for null termination needed #514

Closed lucasw closed 5 months ago

lucasw commented 2 years ago

Without the additional char messages were coming out like this:

Lookup would require extrapolation at time 1628007756.300918579, but only time 1628007759.293766737 is in the buffe, when looking up transform from frame ...
                                                                                                              ^^^^^

buffe is supposed to be buffer, which is fixed by extending the array the error string was put into. It looks like the other lines of similar code for 'into the past' and 'into the future' are doing it properly already.

Should be good until the year 2286 now... but maybe this could be avoided with a macro, less brittle if someone edits the error text of changes the digits of precision?

ahcorde commented 5 months ago

@tfoote @peci1 This was approved but nerve merged. Can we merge this PR ?

peci1 commented 5 months ago

My approval is still valid ;)