search

ros / homebrew-deps

Homebrew Formula for common system ROS dependencies
8 stars 54 forks source link

Drop yaml-cpp-0.3 formula #15

Closed mikepurvis closed 8 years ago

mikepurvis commented 8 years ago

Upstream is 0.5.3: https://github.com/Homebrew/homebrew-core/blob/master/Formula/yaml-cpp.rb

Trusty's version is 0.5.1: http://packages.ubuntu.com/source/trusty/yaml-cpp

Was 0.3 supporting Hydro? If so, that can certainly be dropped at this point.

wjwwood commented 8 years ago

@mikepurvis you'd have to change the rosdep key: https://github.com/ros/rosdistro/blob/be98bc9ad5d275d1e6016adbcd675c044bb02f8e/rosdep/osx-homebrew.yaml#L732-L736

Once you do that, everyone will start using the upstream 0.5 version of yaml-cpp, and so removing this will not be necessary. In light of that, I'll close this. Feel free to continue the discussion and I reopen if necessary.

mikepurvis commented 8 years ago

Done: https://github.com/ros/rosdistro/pull/11287