search

ros / homebrew-deps

Homebrew Formula for common system ROS dependencies
8 stars 54 forks source link

Update to console_bridge 0.3.2 #27

Closed jslee02 closed 7 years ago

jslee02 commented 7 years ago

This PR:

wjwwood commented 7 years ago

Looks like the CI is failing.

jslee02 commented 7 years ago

It seems because pkg-config was not installed while it's required to run the test block.

I added pkg-config dependency as a build dependency.

jslee02 commented 7 years ago

brew test uninstalls all the build dependencies including pkg-config before runs the test block. This is why the CI failed.

I think we might don't want to add pkg-config as a normal dependency of console_bridge only for the test. So I instead changed the test to brew list console_bridge that checks whether it's correctly installed using the Homebrew command.

I'm also open to change the test to something more meaningful since I cannot come up with a better one now.

wjwwood commented 7 years ago

I'm also open to change the test to something more meaningful since I cannot come up with a better one now.

Nah that sounds fine to me as-is. Thanks for iterating on it.