search

ros / homebrew-hydro

Hydro packages and dependencies repository for Homebrew
2 stars 7 forks source link

openni2 does not compile on 10.9 #10

Closed NikolausDemmel closed 10 years ago

NikolausDemmel commented 10 years ago

On Mavericks openni2 does not compile. It's unclear to me what the error is exactly.

https://gist.github.com/NikolausDemmel/7894466

wjwwood commented 10 years ago

I haven't updated to Mavericks yet, hopefully someone else has run into this and can help.

NikolausDemmel commented 10 years ago

Seems to be this issue: https://github.com/OpenNI/OpenNI2/issues/52, and there is a simple patch (have not tried it).

Not sure if we should switch to newer upstream version, or apply a patch. They mention this is fixed in OpenNI devel branch.

wjwwood commented 10 years ago

If that patch works then you can add that as a patch in the formula, at least until a new upstream version is released.

NikolausDemmel commented 10 years ago

It seems to work (at least it compiles). I'll push the updated formula with patch tomorrow and issue a pull request.

NikolausDemmel commented 10 years ago

Thanks for merging, I think we can close this, no?