ros / joint_state_publisher

http://wiki.ros.org/joint_state_publisher

50 stars 81 forks source link

Declare parameters at node initialization #16

Closed cottsay closed 5 years ago

cottsay commented 5 years ago

Also drop dependent_joints and zeros parameters for now. ROS 2 does not support Map parameters right now, so these can't be set to anything without breaking the node.

schornakj commented 5 years ago

I'm interested in this PR as well. Does anything else need to be done here?

cottsay commented 5 years ago

This PR was made prior to Dashing release - I think there may have been late-breaking API changes we need to account for.

I'll put it on my list for next week.

jdlangs commented 5 years ago

Another ping that this fix is needed for anyone trying to use this package.

jdlangs commented 5 years ago

Pinging again to see if there's any update.

schornakj commented 5 years ago

@jdlangs see #23 for an update to this PR with some fixes.

cottsay commented 5 years ago

16 is on a way better track than this PR, which was crafted while the parameter API was still in flux prior to the Dashing release. This approach is not valid when combined with the released parameter API in Dashing, so I'm going to close it in favor of #16.

Thanks for jumping in, @schornakj!