search

ros / joint_state_publisher

http://wiki.ros.org/joint_state_publisher
50 stars 81 forks source link

Make it clear robot_description is required. #39

Closed sloretz closed 4 years ago

sloretz commented 4 years ago

Without this PR

$ rosrun joint_state_publisher_gui  joint_state_publisher_gui
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-sloretz'
Traceback (most recent call last):
  File "/home/sloretz/ws/noetic-misc/devel_isolated/joint_state_publisher_gui/lib/joint_state_publisher_gui/joint_state_publisher_gui", line 15, in <module>
    exec(compile(fh.read(), python_script, 'exec'), context)
  File "/home/sloretz/ws/noetic-misc/src/joint_state_publisher/joint_state_publisher_gui/scripts/joint_state_publisher_gui", line 52, in <module>
    joint_state_publisher.JointStatePublisher(),
  File "<string>", line 157, in __init__
  File "/usr/lib/python3.8/xml/dom/minidom.py", line 1969, in parseString
    return expatbuilder.parseString(string)
  File "/usr/lib/python3.8/xml/dom/expatbuilder.py", line 925, in parseString
    return builder.parseString(string)
  File "/usr/lib/python3.8/xml/dom/expatbuilder.py", line 223, in parseString
    parser.Parse(string, True)
TypeError: a bytes-like object is required, not 'NoneType'

With this PR

$ rosrun joint_state_publisher_gui  joint_state_publisher_gui
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-sloretz'
Traceback (most recent call last):
  File "/home/sloretz/ws/noetic-misc/devel_isolated/joint_state_publisher_gui/lib/joint_state_publisher_gui/joint_state_publisher_gui", line 15, in <module>
    exec(compile(fh.read(), python_script, 'exec'), context)
  File "/home/sloretz/ws/noetic-misc/src/joint_state_publisher/joint_state_publisher_gui/scripts/joint_state_publisher_gui", line 52, in <module>
    joint_state_publisher.JointStatePublisher(),
  File "<string>", line 145, in __init__
RuntimeError: The robot_description parameter is required and not set.
clalancette commented 4 years ago

@sloretz This looks good to me, but I think we need the same fix on the kinetic-devel branch.