ros / meta-ros

OpenEmbedded Layers for ROS 1 and ROS 2
MIT License
373 stars 246 forks source link

Kirkstone #1052

Closed DRK-512 closed 7 months ago

DRK-512 commented 9 months ago

I create and tested a kirksotne branch, and I have gotten rid of all the licenses warnings that come with changing to this yocto version. I feel that a kirkstone branch is beneficial since it is the latest LTS release of Yocto. Note: This will fail the less than 1000 files check since it changes all licenses from BSD->BSD-Clause-3

vmayoral commented 9 months ago

Thanks for re-iterating here @DRK-512. Can you confirm/share with which embedded platforms and Yocto BSPs you validated this? I'm not sure whether we want this into master or if instead we want it in kirkstone branch.

Other than that, no big issues observed from my side.

DRK-512 commented 9 months ago

Can you confirm/share with which embedded platforms

I used an intel64 device and runqemu. The thing is since I only changed licenses, and fixed a fetch issue there should be no worry when it comes to testing on platforms

robwoolley commented 9 months ago

Thanks, DRK-512. I will go through the commits in detail tomorrow and do a test build for ARM64 (ie RPi4).

In our meeting yesterday we discussed using the master branch for the development versions of Yocto and ROS. As such I suggest we merge this into ros:kirkstone instead. Don't worry about submitting another PR. I will start reviewing your changes tomorrow and create a special branch for it.

DRK-512 commented 8 months ago

@robwoolley It seems as if a new branch has not been created just yet, I was just wondering what the progress was on this

robwoolley commented 8 months ago

@DRK-512 Thanks for your patience. I have documented the steps I am taking here: https://docs.google.com/document/d/1hKX7CANu0AEhppPDJAAoMASE2FdZdFzPZZpMj-HI-_o/edit?usp=sharing

Creating a kirkstone branch is the next item on my list. I intend to create a kirkstone-next branch to merge your changes into. This part is quick and easy and might even happen today. This will ensure that your work isn't lost and that you and others can add to it.

Then after I have successfully built the valid kirkstone combinations using the mcf files I can use it to create the kirkstone branch. This next step may take more time doing the builds and fixing build errors can take days.

Hope that helps give you an idea on how things are moving along.

robwoolley commented 7 months ago

Thanks for the fixes. I took the changes that related to the bitbake recipe (.bb) files. I did check each recipe individual and found one that was BSD-2-Clause. I've included the changes in the kirkstone commit series I will be pushing before Monday.