search

ros / meta-ros

OpenEmbedded Layers for ROS 1 and ROS 2
MIT License
373 stars 246 forks source link

Fix Build Failure in ros2_controllers on kirkstone #1080

Closed NaokiTakahashi12 closed 5 months ago

NaokiTakahashi12 commented 6 months ago

Hello, This is my first time sending a pull request to this repository. I tried building ros2_controllers on the kirkstone branch and encountered a build failure due to a missing dependency, generate-parameter-library-py-native. I have submitted a fix for this issue, so please review it. If there are any issues with the pull request, please let me know, and I'll make the necessary corrections. Thank you.

robwoolley commented 6 months ago

Thank you very much for the pull request! I have merged your commit into my kirkstone+humble work where I am fixing the remaining build failures for ros-image-world. I hope to publish the changes to kirkstone-next very soon.

robwoolley commented 6 months ago

I have pushed the commit to kirkstone-next here: https://github.com/ros/meta-ros/commit/4ec87b6ae1a7ca44d01e074e17f945047b47f616

I am still in the process of adding additional patches to kirkstone-next. I will merge the changes into kirkstone when I have had a chance to do some clean builds to ensure everything still builds successfully.

NaokiTakahashi12 commented 5 months ago

Thank you. Is it okay to close this PR?

robwoolley commented 5 months ago

That's fine by me. Thanks for submitting the fix!