search

ros / meta-ros

OpenEmbedded Layers for ROS 1 and ROS 2
MIT License
370 stars 245 forks source link

Apriltag patch does not work #1141

Open mboel opened 1 month ago

mboel commented 1 month ago

I have an issue with the Apriltag package in the Kirkstone branch. The patch in apriltag_3.4.0-1.bbappend is not valid. Removing the patch seems to fix the problem.

robwoolley commented 1 month ago

Thanks for reporting this. I tested with Kirkstone + Humble and reproduced the problem.

It looks like apriltag now has this line: set(PY_DEST ${CMAKE_INSTALL_PREFIX}/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}/site-packages/)

Which causes the patch to fail to apply. I may need to refresh the patch if the hardcoded path

robwoolley commented 1 month ago

I have submitted a fix for apriltag as part of the patch series I am working on. You can find the fix here: https://github.com/ros/meta-ros/pull/1150