ros / meta-ros

OpenEmbedded Layers for ROS 1 and ROS 2
MIT License
391 stars 255 forks source link

{common}: add license map to fix BSD license issue #1256

Closed jiaxshi closed 6 days ago

jiaxshi commented 1 week ago

Since BSD file was removed in YOCTO/scarthgap, some ROS recipes build failed due to cannot find BSD license.

Map BSD to BSD-3-Clause similar to YOCTO/kirkstone.

Fix issue #1208

@robwoolley Could you please review and check if this change is fine to merge?

jiaxshi commented 1 week ago

I know the right way is to ask the maintainer of each projects to add explicitly license context. Before that, how can we use meta-ros? I raised issue on several ROS projects, only got one clear response.

shr-project commented 1 week ago

FWIW: I believe this is wrong and I've replied before with links to superflore where it was discussed how to fix this properly.

But I no longer maintain or use meta-ros, so I don't really mind, just my 2c.

robwoolley commented 6 days ago

I don't feel comfortable using the SPDXLICENSEMAP for BSD, just because I have caught examples in ROS named "BSD" that were not BSD-3-Clause.

Thanks for trying to help though. It is an annoying problem.