ros / pluginlib

Library for loading/unloading plugins in ROS packages during runtime
http://ros.org/wiki/pluginlib
57 stars 101 forks source link

do not use experimental on clang>=10 #209

Closed Karsten1987 closed 3 years ago

Karsten1987 commented 4 years ago

I could not get pluginlib to compile with a homebrew llvm clang. Note this is different of AppleClang which is shipped by default on OSX. The filesystem libraries are marked explicitly unavailable until OSX 10.15. That's the same problem as described here: https://answers.ros.org/question/338832/ros2-source-install-macos-10151-qt_gui_cpp-fails/

Don't have much more info about this though. Some information might be here: https://stackoverflow.com/questions/42633477/macos-clang-c17-filesystem-header-not-found

Might be related to https://github.com/ros/pluginlib/issues/168

As a general question, I am wondering though why we ship pluginlib with this custom logic. It anyways depends on rcpputils already, why not using their filesystem implementation?

clalancette commented 3 years ago

Obsoleted by #212, so closing.