Use rcpputils for the filesystem implementation.

ros / pluginlib

Library for loading/unloading plugins in ROS packages during runtime

http://ros.org/wiki/pluginlib

52 stars 101 forks source link

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

This gets rid of a whole bunch of custom logic and duplicated code around filesystem manipulation.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

If I understand the situation correctly, this should supersede #209, #185, and #184, and may fix #168.

@Karsten1987, @rotu, @jpardeiro FYI.

clalancette commented 3 years ago

CI:

clalancette commented 3 years ago

All right, this has to wait to go in until ros2/rcpputils#112 is merged. After that, it should pass tests.

clalancette commented 3 years ago

@ros-pull-request-builder retest this please

clalancette commented 3 years ago

CI:

clalancette commented 3 years ago

Now that we've merged https://github.com/ros2/rcpputils/pull/118, this should be a lot easier. Let's try CI again:

clalancette commented 3 years ago

The one failing test on macOS often fails on the nightlies: https://ci.ros2.org/view/nightly/job/nightly_osx_repeated/2218/#showFailuresLink . So I'm going to go ahead and merge this.