Fix wShadow compile warning

ros / pluginlib

Library for loading/unloading plugins in ROS packages during runtime

http://ros.org/wiki/pluginlib

52 stars 101 forks source link

Fix wShadow compile warning #250

Closed SteveMacenski closed 10 months ago

SteveMacenski commented 10 months ago

it is defined on L479 and then again in the for loop. Renamed the for look items so that it doesn't compile with warnings turned to errors with -wshadow enabled

SteveMacenski commented 10 months ago

I see there is both a rolling and a ros2 branch, so I selected Rolling but I wasn't sure which

clalancette commented 10 months ago

I see there is both a rolling and a ros2 branch, so I selected Rolling but I wasn't sure which

Yeah, rolling is correct. One of these days we'll make that clear.

clalancette commented 10 months ago

CI:

Linux
Linux-aarch64
Windows

SteveMacenski commented 10 months ago

Sweet! The ticket I linked above can also be closed when this is merged. Found out after I ran into it Ryan reported it as well