Make sure to export the include directory for resource_retriever.

ros / resource_retriever

Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.

8 stars 42 forks source link

Make sure to export the include directory for resource_retriever. #22

Closed clalancette closed 6 years ago

clalancette commented 6 years ago

Otherwise, it can't properly be used as a library.

fixes #21

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

clalancette commented 6 years ago

Linux
Linux-aarch64
macOS
Windows

mikaelarguedas commented 6 years ago

Can you please export the package libraries, interfaces and the include directories before the dependencies? (c.f. ongoing set of PRs for fixing the order of exports)

clalancette commented 6 years ago

Can you please export the package libraries, interfaces and the include directories before the dependencies? (c.f. ongoing set of PRs for fixing the order of exports)

Sure, the latest commit moves it around to the same order as some of the other PRs.

clalancette commented 6 years ago

Thanks for the reviews. I'm fairly certain that the CI failures are unrelated to this PR (the macOS ones look like a bug in rclcpp, while the Windows one looks like a known issue: https://github.com/ros2/build_cop/issues/86). Therefore, I'm going to merge this.