depend on curl (libcurl-dev, curl) for packaging

ros / resource_retriever

Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.

8 stars 42 forks source link

depend on curl (libcurl-dev, curl) for packaging #25

Closed mikaelarguedas closed 6 years ago

mikaelarguedas commented 6 years ago

Defining the dependency on curl allows us to not build it from source but just depend on the upstream version. Copied from: https://github.com/ros2-gbp/resource_retriever-release/tree/5597bf018cfe1bcf3e323c50801bb89c946e9061/ubuntu/libcurl_vendor

The key resolves to libcurl-dev and curl: https://github.com/ros/rosdistro/blob/f236f31615f7eb1667e94cba66f212ddcb80829b/rosdep/base.yaml#L524

@nuclearsandwich @wjwwood @clalancette FYI

mikaelarguedas commented 6 years ago

I'm holding this for now as the new rosdep rule pointing to the virtual package libcurl-dev seems to cause issues on the farm: https://github.com/ros/rosdistro/pull/15308#issuecomment-395269517

nuclearsandwich commented 6 years ago

Since that issue affects us whether we have the dependency here or patched in via the release repository we need to figure it out. The potential solutions I can see in order of most effective to most expedient are

Add support for virtual packages described in https://github.com/ros/rosdistro/pull/15308#issuecomment-395275618
Revert the PR using the libcurl-dev virtual package
Patch the debian/control file for this package in ROS 2 to use the concrete package instead of the virtual one.
Use a locally modified rosdep database when blooming to resolve the key to the concrete package.

mikaelarguedas commented 6 years ago

https://github.com/ros/rosdistro/pull/15308 has been reverted.

This key now points to libcurl4-openssl-dev, curl.

Merging this patch