search

ros / resource_retriever

Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.
8 stars 42 forks source link

Throw exception if package name is empty #54

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

Otherwise, ament_index_cpp will throw a std::runtime_error. Throwing an exception from resource_retriever instead makes for a more useful error message.

ahcorde commented 3 years ago
jacobperron commented 3 years ago

I think this would be good to backport to Foxy (and maybe other distros). For context, this fixes a crash in RViz when loading meshes. It is only expecting exceptions of type resource_retriever::Exception.

jacobperron commented 3 years ago

Backports: