search

ros / resource_retriever

Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.
8 stars 42 forks source link

Remove libcurl_vendor #64

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

Instead rely on system provided version.

@clalancette I went ahead and did this anyways. I'll trigger CI on all platforms to see where we stand.

jacobperron commented 3 years ago
jacobperron commented 3 years ago

I don't have a good solution for Windows (or the time to iterate on this).

felrock commented 2 years ago

Hi, i just ran into this issue here today. And changing to find_package(CURL REQUIRED) fixed it for me. Could a fix for windows just be a simple if-else here, so if windows find libcurl_vendor else find CURL?

clalancette commented 2 years ago

libcurl_vendor should do the appropriate thing if you already have the curl development libraries installed. That is, on Linux, it is just a simple wrapper around the real libraries. If that is not working for you, then something else has gone wrong. Please open a separate issue with details on your platform, what you are trying, and the error output you are getting.

felrock commented 2 years ago

Ok will do that