Split curl dependency to avoid dev package at runtime

ros / resource_retriever

Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.

8 stars 42 forks source link

Split curl dependency to avoid dev package at runtime #67

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

The rosdep keys were (recently) added in ros/rosdistro#31301.

From what I can tell, the curl headers are not needed by packages building against this package, so libcurl-dev doesn't need to be a build_export_depend.

cottsay commented 2 years ago

We should also probably port this over to the ros2 branch as well.

In ROS 2, we're using libcurl_vendor, so this change doesn't apply there.

cottsay commented 2 years ago

I tested this change by building up to resource_retriever, uninstalling libcurl4-openssl-dev, and then continuing the build up to rviz. The build was successful and ldd rviz shows that resource_retriever is linked correctly against libcurl.so.4, which is still installed. So this appears to work as intended.