ros / resource_retriever

Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.
8 stars 42 forks source link

merge libcurl_vendor build instructions #81

Closed jasonbeach closed 1 year ago

jasonbeach commented 1 year ago

I tested these changes on the galactic branch on ubuntu 18.04 and they worked fine. I'm not able to test them on windows or apple. I'm not a fan of pushing in CMAKE_CXX_FLAGS like I am, but am not sure how to otherwise do it.

clalancette commented 1 year ago

Thanks! This is looking great to me now. I'm going to run a couple more tests on it locally. Assuming that is happy, I'll give this a run in CI.

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

All CI seems happy with this, so going ahead and merging. Thank you for the contribution.