search

ros / robot_model

Contains packages for modeling various aspects of robot information, specified in the Xml Robot Description Format (URDF). The core package of this stack is urdf, which parses URDF files, and constructs an object model (C++) of the robot.
http://ros.org/wiki/robot_model
35 stars 104 forks source link

add missing ModelSharedPtr typedefs in indigo #210

Closed v4hn closed 7 years ago

v4hn commented 7 years ago

In the kinetic-devel branch #153 introduced typedefs for the Model class of this package. Later, #206 moved these typedefs over to the urdfdom_compatibility.h header.

The main purpose of this header is to ease compatibility between indigo and kinetic+, so these typedefs should also be provided in indigo-devel.

After we merged this patch for ROS lunar in MoveIt, the missing typedefs break the build of our kinetic-devel on ROS indigo. I guess we are not the only affected project though.

It would be great to see this merged and released in indigo soon!

sloretz commented 7 years ago

@ros-pull-request-builder retest this please

v4hn commented 7 years ago

Does this PR need to be released urgently?

Personally I would like to see it synced before ROSCon in September. :) Other than that, it's not too urgent as long as it will arrive eventually.

Just curious, why is moveit kinetic-devel branch being tested on Indigo?

We aim to retain a stable ABI in indigo (for obvious reasons). So some features in kinetic will not make it back into indigo anymore. However, many robotic setups are still with indigo and we (actually "I", mostly) want to allow developers to run the kinetic branch if they know what they're doing.

clalancette commented 7 years ago

This looks OK to me, passes tests, and is approved. Merging, thanks.

v4hn commented 7 years ago

Ping. How about a release for this in the near future? :-) We are waiting for this patch to come upstream over at moveit.

sloretz commented 7 years ago

Sure, I'll look into doing an indigo release

sloretz commented 7 years ago

@v4hn FYI ros/rosdistro#15775

v4hn commented 7 years ago

Wow, that was fast! thanks a lot @sloretz 🥇