search

ros / ros_comm

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).
http://wiki.ros.org/ros_comm
753 stars 914 forks source link

Dangling if-else triggers compilation error | rosbag_storage #1305

Closed warp1337 closed 6 years ago

warp1337 commented 6 years ago

I am currently building ROS Kinetic from source using the install generator on Gentoo Linux (32 bit) --- actually, all this for the Pepper robot, but that is just FYI.

However, rosbag_storage fails to compile due to two dangling if else statements (1.12.0) in

1st) https://github.com/ros/ros_comm/blob/1.12.10/tools/rosbag_storage/src/lz4_stream.cpp#L180

2nd) https://github.com/ros/ros_comm/blob/lunar-devel/tools/rosbag_storage/src/bz2_stream.cpp#L131

GCC is 5.4.0.

mikepurvis commented 6 years ago

We would welcome a pull request which resolves these issues.

warp1337 commented 6 years ago

Can do. Will take approx. 24 hrs.

warp1337 commented 6 years ago

Since I cannot create a pull request on a tag, how would you like to resolve this?

mikepurvis commented 6 years ago

PR should target the latest devel branch. When we're ready for another release, there will be a new tag. In the immediate term, you can build this repo from source (adjust the generated rosinstall yaml accordingly) or just patch in this one change.

Let's take the discussion to #1306.