search

ros / ros_comm

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).
http://wiki.ros.org/ros_comm
761 stars 912 forks source link

fix char signedness issue for test_base64 on ARM and RISC-V #2205

Open alexfanqi opened 2 years ago

alexfanqi commented 2 years ago

tested on riscv64 and amd64 machines, I am sure ARM should also work.

char on some machines like ARM and RISC-V is by default unsigned. Using signed literals will cause Wnarrow errors from compiler.

I am not sure if this is the most proper fix. And I guess it would be best if the bundled libb64 can be updated because it is more portable and clear to use signed char as decoder and encoder argument.

I am sorry about commit reference noises in the origin issue.