search

ros / ros_comm

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).
http://wiki.ros.org/ros_comm
752 stars 913 forks source link

keep the persistent connection only if rosmaster supports http1.1 #2208

Closed iuhilnehc-ynos closed 2 years ago

iuhilnehc-ynos commented 2 years ago

to fix https://github.com/ros/ros_comm/issues/2182

Signed-off-by: Chen Lihui lihui.chen@sony.com

fujitatomoya commented 2 years ago

@sloretz @jacobperron @mjcarroll friendly ping, requesting maintainer review.

peci1 commented 2 years ago

I confirm this patch fixed #2182 for me on Jetson Xavier AGX (kernel 4.9.253) running Melodic. Also, the performance from #2132 is not affected.

Thanks a lot for investigating!

peci1 commented 2 years ago

Should I take care of the Melodic backport? Or is it planned?

jacobperron commented 2 years ago

Should I take care of the Melodic backport? Or is it planned?

I think a maintainer can include it in a backport PR, e.g. https://github.com/ros/ros_comm/pull/2152