search

ros / ros_comm

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).
http://wiki.ros.org/ros_comm
761 stars 912 forks source link

rosgraph fails to start on Kernels with no minor version number #2221

Open c-rizz opened 2 years ago

c-rizz commented 2 years ago

Hello! I recently updated my machine to kernel 5.16 and on this specific kernel rqt fails to start because of rosgraph crashing. This because of line https://github.com/ros/ros_comm/blob/52b0556dadf3ec0c0bc72df4fc202153a53b539e/tools/rosgraph/src/rosgraph/xmlrpc.py#L92 This happens because platform.release() returns '5.16-051600-generic' and not something like e.g. '5.16.0-051600-generic'. I believe this is a relatively common occurrence. The problem can be solved by changing the line torelease = platform.release().replace("-",".").split('.') Do I submit a pull request?

Thank you for the great tools!

MatthijsBurgh commented 1 year ago

You mean missing patch number 😉