search

ros / ros_comm

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).
http://wiki.ros.org/ros_comm
747 stars 914 forks source link

Allow forwarding of working directory and launch file args to add_rostest from gtest wrapper functions #2294

Open daniel-s-ingram opened 1 year ago

daniel-s-ingram commented 1 year ago

I'm not great with cmake, so there very well may be a better way to do what I'm trying to do here. If this is acceptable, I'll add some unit tests and what not, but I wanted to go ahead and open the PR to get some feedback on whether or not there's a better way to do this.

This would have been more straightforward using a named argument for the sources, but I didn't want to break backwards compatibility.

peci1 commented 1 year ago

Generally, this PR could work. A test-case (utilizing the added features) is almost a must to be sure it actually works.

Could you also describe the scenario where this PR helps?