ros / ros_comm

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).
http://wiki.ros.org/ros_comm
764 stars 912 forks source link

[ROS-O] Fix rostest target names when build dir is inside source dir #2361

Closed v4hn closed 2 months ago

v4hn commented 1 year ago

It's a common approach to build cmake projects in a build folder in the project root. It's just that rosbuild/catkin does not do it, so the changed name never mattered.

When you try, the target name includes another build_ string and there is exactly one package in the whole ecosystem that relies on this not happening: https://github.com/ros/ros_comm/blob/845f74602c7464e08ef5ac6fd9e26c97d0fe42c9/test/test_rosbag/bag_migration_tests/CMakeLists.txt#L87-L103