ros / ros_comm

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).
http://wiki.ros.org/ros_comm
745 stars 911 forks source link

[windows] Remove python2 specific hack #2364

Open gftabor opened 7 months ago

gftabor commented 7 months ago

This PR https://github.com/ros/ros_comm/pull/1872 made windows act differently than linux because of a specific python 2 delay doing unnecessary DNS checks for localhost.

The underlying code in python is different for python3, so the hack should no longer necessary. Given that, it's better to reunify the codebase.

Fixes https://github.com/RoboStack/ros-noetic/issues/430

Standard workflow is source workspace/catkin install and then export environment variables. The current hack makes that workflow not work on windows.