rosbag play formatting problems

[trainman419]

I'm seeing two separate but related issues with the status line from rosbag play:

• For bag files over 100 seconds long, the status line prints repeatedly rather than updating in place. I think this is happening because the status line becomes longer than the terminal width, and the terminal starts auto-wrapping. If I resize my terminal to a width greater than 80 characters, this doesn't happen.
• After closing rosbag using ctrl-C, I don't see my prompt sometimes, and other times it's printed on top of the last status line. Example:

Waiting 0.2 seconds after advertising topics... done.

Hit space to toggle paused, or 's' to step.
hendrix@hendrix:~$ e: 946684965.239850   Duration: 2.102644 / 11856.071320     

[dirk-thomas]

The printing happens around here: https://github.com/ros/ros_comm/blob/81f12203e055371124ebfb71123368e91d5b069e/tools/rosbag/src/player.cpp#L266

In order to adapt the code should dynamically scale the right padding based on the width of the terminal. That way it can truncate it on narrow terminal and still overwrite trailing text on wide terminals. This would also require to handle the signal when the terminal width is changed.

Since we won't have time to work on this feature please consider providing a pull request for it.

[trainman419]

Related: rosbag play doesn't appear to set the terminal flags back when it is done. I have to run stty sane before I can use sudo and vim properly.