Closed pantor closed 8 years ago
:+1: I agree your PR because I often add the Bool.srv for our projects.
We have talked about this and came to the following conclusions:
std_msgs
and std_srvs
should only be used for prototyping since they don't contain any semantic meaning.Trigger
this one would be more specifically names with SetBool
.SetBool
for rapid prototyping though.SetInt
since those would lack too much semantic on the request data (valid value range, unit, etc.).That being said I have cherry-picked a modified version of this with the service name being called SetBool
in 688af918632caef3992bbcf3b73eb325cd5d90a9
Thanks.
I often use a service with an additional bool field in my projects, e.g. for motor enabling/disabling, for switching a notification LED or to turn on/off a laser pointer. Any chance that it might be added to the std_srvs package?