search

ros / ros_tutorials

Code used in tutorials found on ROS wiki
http://wiki.ros.org/ros_tutorials
805 stars 540 forks source link

Missing rolling-devel branch #120

Closed hidmic closed 3 years ago

hidmic commented 3 years ago

There's a tutorial in Rolling that expects the rolling-devel branch to exist here, but there's none. We could drop that reference, but should there be a rolling-devel branch? I see no master nor ros2 branch either. It appears we've been creating distro specific branches as we go here (e.g. see #100).

hidmic commented 3 years ago

FYI @sloretz.

sloretz commented 3 years ago

I'd be fine with any of rolling-devel, master or main. @mabelzhang Any preferences on branch name?

mabelzhang commented 3 years ago

rolling-devel or main or ros2 is fine. For an external contributor, maybe ros2 is the most intuitive to create PRs? main could be ambiguous whether it's ROS 1 or 2.

hidmic commented 3 years ago

For an external contributor, maybe ros2 is the most intuitive to create PRs

Don't have a strong opinion. But I do think we need to branch and get that tutorial fixed.

mabelzhang commented 3 years ago

Looks like the one in common above is rolling-devel, which is also the expected branch. Feel free to create it -- or I can do that if you want. I guess it'd branch off of galactic-devel?

hidmic commented 3 years ago

Just added rolling-devel, branching off of galactic-devel.