Closed Tiryoh closed 2 years ago
Thanks for your efforts @Tiryoh , using rosparam is great!
Using a ROS parameter to disable holonomic motions sounds okay to me.
I'm closing this issue because the PR has been merged to the rolling branch.
https://github.com/ros/ros_tutorials/pull/131
Thanks @tianb03, @jacobperron, @audrow!
I created the issue #93 and the related PR because I believe it will be useful in introducing beginners that it is possible to work with holonomic motion. However, it seems that if this option is always enabled, it may sometimes disturb the learning process for beginning students. This is not what I want to do.
_Originally posted by @tianb03 in https://github.com/ros/ros_tutorials/issues/93#issuecomment-869282435_
I think It would be nice to have an option to disable holonomic motion as @jacobperron mentions, so I'm going to submit a pull request for the option to disable it. How do you think the options should be able to be specified, @tianb03, @jacobperron? (If I should ask someone else, please let me know.) I believe that rosparam is easier to specifying both from the command line and the roslaunch like the teleop_twist_keyboard.
e.g.)