search

ros / ros_tutorials

Code used in tutorials found on ROS wiki
http://wiki.ros.org/ros_tutorials
787 stars 537 forks source link

Add holonomic motion disable option (ROS 1 turtlesim) #130

Closed Tiryoh closed 2 years ago

Tiryoh commented 3 years ago

This PR adds an option to turtlesim to disable holonomic motion.

Related issue: https://github.com/ros/ros_tutorials/issues/127

Usage 

rosrun turtlesim turtlesim_node _holonomic:=false
<arg name="holonomic" default="false" />
<node pkg="turtlesim" name="sim" type="turtlesim_node">
  <param name="holonomic" value="$(arg false)" />
</node>

Screenshot from 2021-07-11 03-04-42

Note that the most right terminal shows the teleop_twist_keyboard.py, which is not contained in this PR.

audrow commented 2 years ago

I'm going to close this since it breaks API / ABI and there will be now future releases of ROS 1, see https://github.com/ros/ros_tutorials/pull/131#issuecomment-975925266.

Tiryoh commented 2 years ago

I had forgotten to close this. Thanks for checking!