search

ros / ros_tutorials

Code used in tutorials found on ROS wiki
http://wiki.ros.org/ros_tutorials
805 stars 540 forks source link

Heavy cleanup of the draw_square tutorial. #152

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

In particular:

  1. Make it conform to the current ROS 2 style.
  2. Add in copyright information.
  3. Refactor the entire code into a class, which tidies it up quite a bit and removes a bunch of globals.
  4. Make sure to wait for the reset to complete before trying to move the turtle.
clalancette commented 1 year ago

Does it make sense to include ament_lint_auto ?

It's a good question. I ended up not doing this because I would then have to change the style of all of the files in this package, and I wanted to concentrate on fixing draw_square for now. I think we should eventually clean this up and do that, but as a separate PR.

That said, I'll do the updates you suggest above.

clalancette commented 1 year ago

CI:

gavanderhoorn commented 1 month ago

@clalancette: could this potentially be backported to humble?

Without these changes, it looks like draw_square is broken on Humble.