Closed jokane closed 11 months ago
Thanks for making the icons consistent!
The recommend workflow is to target fixes to the rolling
branch. Once merged, changes will be backported to other distro branches if needed.
Replacing with #158, which targets rolling
as requested.
This PR crops the images in turtlesim/images for galactic and rolling to be 45x45, from their current 48x48 size. This is relevant because the image size apparently plays a role in how the internal coordinates are mapped to specific places on the turtlesim window.
Here's an example of what happens when I spawn 100 turtles, all at x=5.544444, y=5.544444, theta=0.0, without moving any of them.
The result is incorrect because some of the turtles --always those shown with galactic.png or rolling.png-- appear further down and to the right.
This offset persists when the turtles move, which causes coordinated drawings by multiple turtles to be out-of-sync. Here's an example where top part of the "A", drawn by the galactic turtle, is shifted down and to the right of where it should be:![image](https://github.com/ros/ros_tutorials/assets/4633775/52e4bb79-2044-41fc-a25c-e746628caead)
The issue seems to be related to differing sizes of the turtle images:
By cropping a few pixels of transparent border from these two images, down to 45x45 to match the other turtles, the problem is resolved:![image](https://github.com/ros/ros_tutorials/assets/4633775/98baf8a8-4eb3-4994-b823-848d3dec527d)
(Submitted, as first-time contributor to ROS, with my apologies if I've not formed the PR correctly.)