Use same QoS for all topic pub/subs

ros / ros_tutorials

Code used in tutorials found on ROS wiki

http://wiki.ros.org/ros_tutorials

787 stars 537 forks source link

Use same QoS for all topic pub/subs #161

Closed Yadunund closed 7 months ago

Yadunund commented 7 months ago

This PR ensures that all topic publishers and subscriptions are configured with the same QoS settings. Given that the history depth for the turtle1/pose subscription was previously 1, I would observe the draw_square executable would sometimes wait indefinitely if the message was dropped. This could happen if the Default reliability is BEST_EFFORT instead of RELIABLE. With the changes, the reliability is RELIABLE and all pub/subs have compatible settings.

clalancette commented 7 months ago

Did CI get run on this PR?

ahcorde commented 7 months ago

my bad, here we go:

Linux
Linux-aarch64
Windows

Yadunund commented 7 months ago

I think CI is failing because the branch was deleted. I've triggered a rebuild after restoring the branch.

ahcorde commented 7 months ago

Thank you @Yadunund, all good @clalancette